This repository was archived by the owner on Jul 22, 2025. It is now read-only.
FIX: legacy reasoning models not working, missing provider params #1149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SamSaffron
commented
Feb 24, 2025
SamSaffron
commented
- Legacy reasoning models (o1-preview / o1-mini) do not support developer or system messages, do not use them.
- LLM editor form not showing all provider params due to missing remap
1. Legacy reasoning models (o1-preview / o1-mini) do not support developer or system messages, do not use them. 2. LLM editor form not showing all provider params due to missing remap
Contributor
|
@SamSaffron I'm not familiar with the plugin and its constraints but I'm curious why we opted not to test the fix here. |
Member
Author
|
The UI needs a system test, I agree with that, but the the backend is pretty fluid ad open ai break stuff all the time, so I think the backend fix is OK without a test. will see if I can add 1 system test for llm editing... we have none I guess. |
tgxworld
approved these changes
Feb 24, 2025
Contributor
tgxworld
left a comment
tgxworld
left a comment
There was a problem hiding this comment.
Approving first as the fix looks good to me.
Member
Author
|
@tgxworld added a system test, oddly enough we covered a lot here just missed the edit case. |
Contributor
Looks good to me 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.